[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [RFC v2 1/4] hw/intc/arm_gicv3_its: Don't abort on table
From: |
Auger Eric |
Subject: |
Re: [Qemu-arm] [RFC v2 1/4] hw/intc/arm_gicv3_its: Don't abort on table save failure |
Date: |
Mon, 6 Nov 2017 11:09:18 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Hi Peter,
On 02/11/2017 13:53, Peter Maydell wrote:
> On 23 October 2017 at 16:35, Eric Auger <address@hidden> wrote:
>> The ITS is not fully properly reset at the moment. Caches are
>> not emptied.
>>
>> After a reset, in case we attempt to save the state before
>> the bound devices have registered their MSIs and after the
>> 1st level table has been allocated by the ITS driver
>> (device BASER is valid), the first level entries are still
>> invalid. If the device cache is not empty (devices registered
>> before the reset), vgic_its_save_device_tables fails with -EINVAL.
>> This causes a QEMU abort().
>>
>> Signed-off-by: Eric Auger <address@hidden>
>> Reported-by: wanghaibin <address@hidden>
>>
>> ---
>>
>> this patch would deserve being cc'ed stable (2.10)
>> This goes along with patches 1-5 of
>> [PATCH v5 00/10] vITS Migration fixes and reset, candidate
>> for being cc'ed stable
>> ---
>
> Reviewed-by: Peter Maydell <address@hidden>
>
> We could/should put this patch into qemu now, right (it's
> the rest of the series that's RFC) ?
Yes that's correct.
Thanks
Eric
>
> thanks
> -- PMM
>