[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method su
From: |
Peter Maydell |
Subject: |
[Qemu-arm] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded |
Date: |
Thu, 7 Dec 2017 18:14:48 +0000 |
We were passing a NULL error pointer to the object_property_set_bool()
call that realizes the CPU object. This meant that we wouldn't detect
failure, and would plough blindly on to crash later trying to use a
NULL CPU object pointer. Detect errors and fail instead.
In particular, this will be necessary to detect the user error
of using "-cpu host" without "-enable-kvm" once we make the host
CPU type be registered unconditionally rather than only in
kvm_arch_init().
Signed-off-by: Peter Maydell <address@hidden>
---
hw/arm/virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 151592b..62af013 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1402,7 +1402,7 @@ static void machvirt_init(MachineState *machine)
"secure-memory", &error_abort);
}
- object_property_set_bool(cpuobj, true, "realized", NULL);
+ object_property_set_bool(cpuobj, true, "realized", &error_fatal);
object_unref(cpuobj);
}
fdt_add_timer_nodes(vms);
--
2.7.4
- [Qemu-arm] [PATCH 0/6] arm: support -cpu max (and gic-version=max), Peter Maydell, 2017/12/07
- [Qemu-arm] [PATCH 6/6] hw/arm/virt: Support -machine gic-version=max, Peter Maydell, 2017/12/07
- [Qemu-arm] [PATCH 2/6] target/arm: Query host CPU features on-demand at instance init, Peter Maydell, 2017/12/07
- [Qemu-arm] [PATCH 3/6] target/arm: Move definition of 'host' cpu type into cpu.c, Peter Maydell, 2017/12/07
- [Qemu-arm] [PATCH 5/6] hw/arm/virt: Add "max" to the list of CPU types "virt" supports, Peter Maydell, 2017/12/07
- [Qemu-arm] [PATCH 4/6] target/arm: Add "-cpu max" support, Peter Maydell, 2017/12/07
- [Qemu-arm] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded,
Peter Maydell <=
- Re: [Qemu-arm] [PATCH 0/6] arm: support -cpu max (and gic-version=max), Peter Maydell, 2017/12/07