[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v3] Virt: ACPI: fix qemu assert due to re-assigned

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH v3] Virt: ACPI: fix qemu assert due to re-assigned table data address
Date: Mon, 8 Jan 2018 12:11:34 +0000

On 28 December 2017 at 08:20, Andrew Jones <address@hidden> wrote:
> On Thu, Dec 28, 2017 at 09:14:40AM +0800, Shannon Zhao wrote:
>> From: Zhaoshenglong <address@hidden>
>> acpi_data_push uses g_array_set_size to resize the memory size. If there
>> is no enough contiguous memory, the address will be changed. If we use
>> the old value, it will assert.
>> qemu-kvm: hw/acpi/bios-linker-loader.c:214: bios_linker_loader_add_checksum:
>> Assertion `start_offset < file->blob->len' failed.`
>> This issue only happens in building SRAT table now but here we unify the
>> pattern for other tables as well to avoid possible issues in the future.
>> Signed-off-by: Zhaoshenglong <address@hidden>
>> ---
>> v3: unify the pattern for MCFG
>> v2: update the commit message according to Andrew's comments
>> ---
>>  hw/arm/virt-acpi-build.c | 18 +++++++++++-------
>>  1 file changed, 11 insertions(+), 7 deletions(-)
> Reviewed-by: Andrew Jones <address@hidden>

Thanks; applied to target-arm.next.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]