[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH] target/arm: Make disas_thumb2_insn() generate its

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH] target/arm: Make disas_thumb2_insn() generate its own UNDEF exceptions
Date: Tue, 9 Jan 2018 14:22:23 +0000

On 12 December 2017 at 17:39, Richard Henderson
<address@hidden> wrote:
> On 12/12/2017 04:08 AM, Peter Maydell wrote:
>> Refactor disas_thumb2_insn() so that it generates the code for raising
>> an UNDEF exception for invalid insns, rather than returning a flag
>> which the caller must check to see if it needs to generate the UNDEF
>> code. This brings the function in to line with the behaviour of
>> disas_thumb_insn() and disas_arm_insn().
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> This fixes the odd asymmetry of API that caused the bug fixed
>> in commit 7472e2efb...
>> ---
>>  target/arm/translate.c | 23 ++++++++++-------------
>>  1 file changed, 10 insertions(+), 13 deletions(-)
> Reviewed-by: Richard Henderson <address@hidden>

Thanks; applied to target-arm.next.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]