Re: [Qemu-arm] [PATCH 5/9] target/arm: Add aa32_vfp_dreg/aa64_vfp_qreg helpers

[Richard Henderson]

On 01/11/2018 10:39 AM, Peter Maydell wrote:
> On 18 December 2017 at 17:30, Richard Henderson
> <address@hidden> wrote:
>> Helpers that return a pointer into env->vfp.regs so that we isolate
>> the logic of how to index the regs array for different cpu modes.
>>
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>>  target/arm/cpu.h           | 20 +++++++++++++++++++-
>>  linux-user/signal.c        | 22 ++++++++++++----------
>>  target/arm/arch_dump.c     |  8 +++++---
>>  target/arm/helper-a64.c    | 13 +++++++------
>>  target/arm/helper.c        | 32 ++++++++++++++++++++------------
>>  target/arm/kvm32.c         |  4 ++--
>>  target/arm/kvm64.c         | 31 ++++++++++---------------------
>>  target/arm/machine.c       |  2 +-
>>  target/arm/translate-a64.c | 25 ++++++++-----------------
>>  target/arm/translate.c     | 16 +++++++++-------
>>  10 files changed, 93 insertions(+), 80 deletions(-)
>>
>> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
>> index 7a705a09a1..e1a8e2880d 100644
>> --- a/target/arm/cpu.h
>> +++ b/target/arm/cpu.h
>> @@ -493,7 +493,7 @@ typedef struct CPUARMState {
>>           * the two execution states, and means we do not need to explicitly
>>           * map these registers when changing states.
>>           */
>> -        float64 regs[64] QEMU_ALIGNED(16);
>> +        uint64_t regs[64] QEMU_ALIGNED(16);
> 
> Why are we changing the type of this field ?

Because that's how it's actually used.  We were using casts before.


r~