[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH v4 09/14] pci: Add support for Design

From: Marcel Apfelbaum
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block
Date: Wed, 17 Jan 2018 18:12:51 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 17/01/2018 17:35, Peter Maydell wrote:
On 17 January 2018 at 15:23, Marcel Apfelbaum <address@hidden> wrote:

On 16/01/2018 16:34, Peter Maydell wrote:
On 16 January 2018 at 01:37, Andrey Smirnov <address@hidden>
I'm not familiar enough with our PCI code to be able to review
this, I'm afraid. MST and Marcel are our PCI subsystem maintainers --
could one of you have a look at whether this seems to be a correct
implementation of a pcie host controller ?

Sadly PCI Host bridges do not have a standard, each HW vendor
can do pretty much what they want.

That being said, if Andrey can point me to the PCI spec for the Designware
PCI host bridge and what parts they implemented for it I can have a look,

I'm not so worried about whether it's implementing the spec for
the hardware (I trust Andrey has done enough testing for that
side of things), but whether the code seems to be structured
the way we expect a QEMU pcie host controller to be structured,
is using the right APIs, and so on.

Got it, I'll review in a week.


-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]