[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 1/6] hw/arm/virt: Check that the CPU realize metho

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded
Date: Fri, 26 Jan 2018 14:34:04 +0000

On 26 January 2018 at 14:32, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 12/07/2017 03:14 PM, Peter Maydell wrote:
>> We were passing a NULL error pointer to the object_property_set_bool()
>> call that realizes the CPU object. This meant that we wouldn't detect
>> failure, and would plough blindly on to crash later trying to use a
>> NULL CPU object pointer. Detect errors and fail instead.
>> In particular, this will be necessary to detect the user error
>> of using "-cpu host" without "-enable-kvm" once we make the host
>> CPU type be registered unconditionally rather than only in
>> kvm_arch_init().
>> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Thanks; I already put this patch in master (commit c88bc3e0dbe7), though.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]