Re: [Qemu-arm] [PATCH v2 38/67] target/arm: Implement SVE Partition Break Group

[Peter Maydell]

On 17 February 2018 at 18:22, Richard Henderson
<address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/helper-sve.h    |  18 ++++
>  target/arm/sve_helper.c    | 247 
> +++++++++++++++++++++++++++++++++++++++++++++
>  target/arm/translate-sve.c |  96 ++++++++++++++++++
>  target/arm/sve.decode      |  19 ++++
>  4 files changed, 380 insertions(+)


> +        b = g & n;            /* guard true, pred true*/

missing space before */

> +/* Given a computation function, compute a merging BRK.  */
> +static void compute_brk_m(uint64_t *d, uint64_t *n, uint64_t *g,
> +                          intptr_t oprsz, bool after)

Comment says "given a computation function" but the prototype
doesn't take a function as parameter ?

> +{
> +    bool brk = false;
> +    intptr_t i;
> +
> +    for (i = 0; i < DIV_ROUND_UP(oprsz, 8); ++i) {
> +        uint64_t this_b, this_g = g[i];
> +
> +        brk = compute_brk(&this_b, n[i], this_g, brk, after);
> +        d[i] = (this_b & this_g) | (d[i] & ~this_g);
> +    }
> +}
> +

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM