Re: [Qemu-arm] [Qemu-devel] [PATCH v3 13/16] target/arm: Decode aa32 armv8.3 3-same

[Peter Maydell]

On 28 February 2018 at 19:31, Richard Henderson
<address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/translate.c | 68 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 68 insertions(+)

> @@ -8424,6 +8486,12 @@ static void disas_arm_insn(DisasContext *s, unsigned 
> int insn)
>                      }
>                  }
>              }
> +        } else if ((insn & 0x0e000a00) == 0x0c000800
> +                   && arm_dc_feature(s, ARM_FEATURE_V8)) {
> +            if (disas_neon_insn_3same_ext(s, insn)) {
> +                goto illegal_op;
> +            }
> +            return;
>          } else if ((insn & 0x0fe00000) == 0x0c400000) {
>              /* Coprocessor double register transfer.  */
>              ARCH(5TE);

Oh yes, shouldn't there be a similar fragment in disas_thumb2_insn()
to take care of the Thumb encodings of these insns ?

thanks
-- PMM