[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 6/9] hw/arm/bcm2836: Create proper bcm2837 device
From: |
Andrew Baumann |
Subject: |
Re: [Qemu-arm] [PATCH 6/9] hw/arm/bcm2836: Create proper bcm2837 device |
Date: |
Tue, 13 Mar 2018 16:47:30 +0000 |
> From: Peter Maydell <address@hidden>
> Sent: Tuesday, 13 March 2018 08:35
>
> The bcm2837 is pretty similar to the bcm2836, but it does have
> some differences. Notably, the MPIDR affinity aff1 values it
> sets for the CPUs are 0x0, rather than the 0xf that the bcm2836
> uses, and if this is wrong Linux will not boot.
>
> Rather than trying to have one device with properties that
> configure it differently for the two cases, create two
> separate QOM devices for the two SoCs. We use the same approach
> as hw/arm/aspeed_soc.c and share code and have a data table
> that might differ per-SoC. For the moment the two types don't
> actually have different behaviour.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> include/hw/arm/bcm2836.h | 19 +++++++++++++++++++
> hw/arm/bcm2836.c | 37 ++++++++++++++++++++++++++++++++-----
> hw/arm/raspi.c | 3 ++-
> 3 files changed, 53 insertions(+), 6 deletions(-)
I haven't tried to understand enough of QOM to review this one... (It looks
sane to me though.)
Andrew
- Re: [Qemu-arm] [Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type, (continued)
Re: [Qemu-arm] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type, Philippe Mathieu-Daudé, 2018/03/13
Re: [Qemu-arm] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type, Peter Maydell, 2018/03/19
[Qemu-arm] [PATCH 7/9] hw/arm/bcm2836: Use correct affinity values for BCM2837, Peter Maydell, 2018/03/13
[Qemu-arm] [PATCH 6/9] hw/arm/bcm2836: Create proper bcm2837 device, Peter Maydell, 2018/03/13
[Qemu-arm] [PATCH 5/9] hw/arm/bcm2836: Rename bcm2836 type/struct to bcm283x, Peter Maydell, 2018/03/13
[Qemu-arm] [PATCH 4/9] hw/arm/bcm2386: Fix parent type of bcm2386, Peter Maydell, 2018/03/13
[Qemu-arm] [PATCH 3/9] hw/arm/boot: If booting a kernel in EL2, set SCR_EL3.HCE, Peter Maydell, 2018/03/13
[Qemu-arm] [PATCH 2/9] hw/arm/boot: assert that secure_boot and secure_board_setup are false for AArch64, Peter Maydell, 2018/03/13