[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEM
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU |
Date: |
Tue, 15 May 2018 15:51:42 +0100 |
On 15 May 2018 at 15:46, Richard Henderson <address@hidden> wrote:
> On 05/15/2018 06:25 AM, Peter Maydell wrote:
>> I guess that having the compiler check is better than finding them
>> later with coverity. It's a shame gcc doesn't support the standard
>> mechanism of using /* fallthrough */ to mark these, though.
>
> It does. Apparently not by default anymore, however:
>
> @item @option{-Wimplicit-fallthrough=0} disables the warning altogether.
>
> @item @option{-Wimplicit-fallthrough=1} matches @code{.*} regular
> expression, any comment is used as fallthrough comment.
>
> @item @option{-Wimplicit-fallthrough=2} case insensitively matches
> @code{.*falls?[ \t-]*thr(ough|u).*} regular expression.
>
> @item @option{-Wimplicit-fallthrough=3} case sensitively matches one of the
> following regular expressions:
> ...
>
> I think either =2 or =1 would work for us in QEMU.
1 sounds too broad, we don't want any old comment to count.
2 is probably what we want.
thanks
-- PMM
- [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Stefan Weil, 2018/05/13
- Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Stefan Weil, 2018/05/13
- Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Peter Maydell, 2018/05/13
- Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Peter Maydell, 2018/05/15
- Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Stefan Weil, 2018/05/15
- Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Peter Maydell, 2018/05/15
- Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Richard Henderson, 2018/05/15
- Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU,
Peter Maydell <=
- Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Peter Maydell, 2018/05/18
- Re: [Qemu-arm] [Qemu-devel] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Richard Henderson, 2018/05/18
- Re: [Qemu-arm] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU, Peter Maydell, 2018/05/17