[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 13/27] Make address_space_translate_iommu take a M
From: |
Alex Bennée |
Subject: |
Re: [Qemu-arm] [PATCH 13/27] Make address_space_translate_iommu take a MemTxAttrs argument |
Date: |
Tue, 22 May 2018 12:00:44 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Peter Maydell <address@hidden> writes:
> As part of plumbing MemTxAttrs down to the IOMMU translate method,
> add MemTxAttrs as an argument to address_space_translate_iommu().
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> exec.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index af2b82d154..c3baadc349 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -478,6 +478,7 @@ address_space_translate_internal(AddressSpaceDispatch *d,
> hwaddr addr, hwaddr *x
> * @is_write: whether the translation operation is for write
> * @is_mmio: whether this can be MMIO, set true if it can
> * @target_as: the address space targeted by the IOMMU
> + * @attrs: transaction attributes
> *
> * This function is called from RCU critical section. It is the common
> * part of flatview_do_translate and address_space_translate_cached.
> @@ -488,7 +489,8 @@ static MemoryRegionSection
> address_space_translate_iommu(IOMMUMemoryRegion *iomm
> hwaddr
> *page_mask_out,
> bool is_write,
> bool is_mmio,
> - AddressSpace
> **target_as)
> + AddressSpace
> **target_as,
> + MemTxAttrs attrs)
> {
> MemoryRegionSection *section;
> hwaddr page_mask = (hwaddr)-1;
> @@ -572,7 +574,7 @@ static MemoryRegionSection flatview_do_translate(FlatView
> *fv,
> return address_space_translate_iommu(iommu_mr, xlat,
> plen_out, page_mask_out,
> is_write, is_mmio,
> - target_as);
> + target_as, attrs);
> }
> if (page_mask_out) {
> /* Not behind an IOMMU, use default page size. */
> @@ -3735,7 +3737,7 @@ static inline MemoryRegion
> *address_space_translate_cached(
>
> section = address_space_translate_iommu(iommu_mr, xlat, plen,
> NULL, is_write, true,
> - &target_as);
> + &target_as, attrs);
> return section.mr;
> }
--
Alex Bennée
- [Qemu-arm] [PATCH 00/27] iommu: support txattrs, support TCG execution, implement TZ MPC, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 01/27] memory.h: Improve IOMMU related documentation, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 13/27] Make address_space_translate_iommu take a MemTxAttrs argument, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 07/27] Make memory_region_access_valid() take a MemTxAttrs argument, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 08/27] Make MemoryRegion valid.accepts callback take a MemTxAttrs argument, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 11/27] Make address_space_get_iotlb_entry() take a MemTxAttrs argument, Peter Maydell, 2018/05/21