[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 09/27] Make flatview_access_valid() take a MemTxAt
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH 09/27] Make flatview_access_valid() take a MemTxAttrs argument |
Date: |
Tue, 22 May 2018 17:37:19 +0100 |
On 22 May 2018 at 17:33, Richard Henderson <address@hidden> wrote:
> On 05/21/2018 07:03 AM, Peter Maydell wrote:
>> As part of plumbing MemTxAttrs down to the IOMMU translate method,
>> add MemTxAttrs as an argument to flatview_access_valid().
>> Its callers now all have an attrs value to hand, so we can
>> correct our earlier temporary use of MEMTXATTRS_UNSPECIFIED.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>> /* When our callers all have attrs we'll pass them through here
>> */
>> - if (!memory_region_access_valid(mr, xlat, l, is_write,
>> - MEMTXATTRS_UNSPECIFIED)) {
>> + if (!memory_region_access_valid(mr, xlat, l, is_write, attrs)) {
>
> Kill the temporary comment too.
Oops, yes.
thanks
-- PMM
- Re: [Qemu-arm] [Qemu-devel] [PATCH 17/27] exec.c: Handle IOMMUs in address_space_translate_for_iotlb(), (continued)
- [Qemu-arm] [PATCH 04/27] Make address_space_map() take a MemTxAttrs argument, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 24/27] hw/misc/iotkit-secctl.c: Implement SECMPCINTSTATUS, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 25/27] hw/arm/iotkit: Instantiate MPC, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 09/27] Make flatview_access_valid() take a MemTxAttrs argument, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 06/27] Make flatview_extend_translation() take a MemTxAttrs argument, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 12/27] Make flatview_do_translate() take a MemTxAttrs argument, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 10/27] Make flatview_translate() take a MemTxAttrs argument, Peter Maydell, 2018/05/21
- [Qemu-arm] [PATCH 20/27] hw/misc/tz-mpc.c: Implement correct blocked-access behaviour, Peter Maydell, 2018/05/21