[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 1/8] sdcard: Update the Configuration Register (SC
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [PATCH 1/8] sdcard: Update the Configuration Register (SCR) to Spec Version 1.10 |
|
Date: |
Thu, 7 Jun 2018 16:16:05 +0100 |
On 7 June 2018 at 16:14, Philippe Mathieu-Daudé <address@hidden> wrote:
> The current codebase is a mix of v1 registers and v2 commands (which
> were added slowly without updating all registers).
> As of now v1 is broken (See the lm3s6965evb machine can not use the
> card) and all users are using v2.
> My goal with these series is to also support v3.
>
> It might be more obvious to first enforce the current implementation is
> v2, then restore v1 support and go for v3. I think this is doable by an
> easy rebase of this series (keep v2 and restore v1).
>
> Do you think this is better?
I don't have a strong opinion (you have a better grasp of the specs
than me); I'd just like justification for why we do what we do
in the commit messages and/or comments as appropriate.
thanks
-- PMM
- [Qemu-arm] [PATCH 0/8] sdcard: cleanup the SD_SPEC version, Philippe Mathieu-Daudé, 2018/06/02
- [Qemu-arm] [PATCH 2/8] sdcard: Allow commands valid in SPI mode, Philippe Mathieu-Daudé, 2018/06/02
- [Qemu-arm] [PATCH 3/8] sdcard: Add a 'spec_version' property, Philippe Mathieu-Daudé, 2018/06/02
- [Qemu-arm] [PATCH 4/8] sdcard: Set Spec v2.00 as default, Philippe Mathieu-Daudé, 2018/06/02
- [Qemu-arm] [PATCH 5/8] hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10, Philippe Mathieu-Daudé, 2018/06/02