[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v4 00/40] Use the IEC binary prefix definitions
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v4 00/40] Use the IEC binary prefix definitions |
Date: |
Mon, 11 Jun 2018 17:11:36 +0100 |
On 11 June 2018 at 16:55, Eric Blake <address@hidden> wrote:
> On 06/10/2018 08:14 PM, Philippe Mathieu-Daudé wrote:
>>
>> Hi,
>>
>> This series:
>>
>> - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.h"
>> (this now triggers WARNING: 1 added file, does MAINTAINERS need
>> updating?)
>> - clean hw/ includes;
>> - replace different constants used for byte size with their corresponding
>> IEC binary prefix definitions.
>>
>> Since v3:
>> - use IEC binary prefix definitions (Stefan Weil)
>> - rebased
>> - added R-b tags
>>
>
>> hw/net/ne2000.h | 5 ++--
>
> ...
>>
>> tests/test-qemu-opts.c | 7 +++---
>> scripts/checkpatch.pl | 1 +
>> 135 files changed, 533 insertions(+), 431 deletions(-)
>> create mode 100644 include/qemu/units.h
>>
>
> At least monitor.c and vl.c are missing from this list; a more general grep
> shows that the following are all potential candidates for this cleanup:
This patchset is already 40 patches long, though; if we like it
then we should just go ahead with it and deal with the stragglers
in a second series.
thanks
-- PMM
- [Qemu-arm] [PATCH v4 06/40] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h", (continued)
- [Qemu-arm] [PATCH v4 06/40] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-arm] [PATCH v4 05/40] hw: Use IEC binary prefix definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-arm] [PATCH v4 14/40] hw/display: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-arm] [PATCH v4 34/40] hw/net: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- Re: [Qemu-arm] [PATCH v4 00/40] Use the IEC binary prefix definitions, Michael S. Tsirkin, 2018/06/10
- Re: [Qemu-arm] [PATCH v4 00/40] Use the IEC binary prefix definitions, Eric Blake, 2018/06/11
- Re: [Qemu-arm] [PATCH v4 00/40] Use the IEC binary prefix definitions, Cornelia Huck, 2018/06/11