[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH for-3.0 0/2] accel/tcg: fix get_page_addr_code() v
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [PATCH for-3.0 0/2] accel/tcg: fix get_page_addr_code() victim TLB lookups |
|
Date: |
Mon, 16 Jul 2018 17:27:31 +0100 |
On 13 July 2018 at 15:16, Peter Maydell <address@hidden> wrote:
> This patchset fixes a bug in get_page_addr_code()'s
> lookup of the address in the victim TLB, which was another
> source of "we end up with an invalid TLB entry even after
> we've done a TLB fill for it".
>
> The second patch then removes a check that we had that was
> working around the existence of the bug patch 1 fixes and
> the bug that commit 68fea038553039e fixes, and instead
> puts in an assertion that we definitely do have a valid TLB.
>
> Tested with Laurent's m68k image to check we didn't regress that.
Thanks for the review -- I'll take these via target-arm.next
since RTH doesn't have any other tcg patches for rc1.
-- PMM