[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] hw/arm/sysbus-fdt: Fix assertion in copy_properti
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [PATCH] hw/arm/sysbus-fdt: Fix assertion in copy_properties_from_host() |
|
Date: |
Mon, 30 Jul 2018 14:50:25 +0100 |
On 25 July 2018 at 12:30, Geert Uytterhoeven <address@hidden> wrote:
> When copy_properties_from_host() ignores the error for an optional
> property, it frees the error, but fails to reset it.
>
> Hence if two or more optional properties are missing, an assertion is
> triggered:
>
> util/error.c:57: error_setv: Assertion `*errp == NULL' failed.
>
> Fis this by resetting err to NULL after ignoring the error.
>
> Fixes: 9481cf2e5f2f2bb6 ("hw/arm/sysbus-fdt: helpers for clock node
> generation")
> Signed-off-by: Geert Uytterhoeven <address@hidden>
Thanks, applied to target-arm.next for 3.0.
-- PMM