[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cm
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-arm] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw |
Date: |
Wed, 1 Aug 2018 15:28:26 +0200 |
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson
<address@hidden> wrote:
> The normal vector element is sign-extended before
> comparing with the wide vector element.
>
> Reported-by: Laurent Desnogues <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Laurent Desnogues <address@hidden>
Tested-by: Laurent Desnogues <address@hidden>
Laurent
> ---
> target/arm/sve_helper.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
> index 54795c9194..9bd0694d55 100644
> --- a/target/arm/sve_helper.c
> +++ b/target/arm/sve_helper.c
> @@ -2436,13 +2436,13 @@ uint32_t HELPER(NAME)(void *vd, void *vn, void *vm,
> void *vg, uint32_t desc) \
> #define DO_CMP_PPZW_S(NAME, TYPE, TYPEW, OP) \
> DO_CMP_PPZW(NAME, TYPE, TYPEW, OP, H1_4, 0x1111111111111111ull)
>
> -DO_CMP_PPZW_B(sve_cmpeq_ppzw_b, uint8_t, uint64_t, ==)
> -DO_CMP_PPZW_H(sve_cmpeq_ppzw_h, uint16_t, uint64_t, ==)
> -DO_CMP_PPZW_S(sve_cmpeq_ppzw_s, uint32_t, uint64_t, ==)
> +DO_CMP_PPZW_B(sve_cmpeq_ppzw_b, int8_t, uint64_t, ==)
> +DO_CMP_PPZW_H(sve_cmpeq_ppzw_h, int16_t, uint64_t, ==)
> +DO_CMP_PPZW_S(sve_cmpeq_ppzw_s, int32_t, uint64_t, ==)
>
> -DO_CMP_PPZW_B(sve_cmpne_ppzw_b, uint8_t, uint64_t, !=)
> -DO_CMP_PPZW_H(sve_cmpne_ppzw_h, uint16_t, uint64_t, !=)
> -DO_CMP_PPZW_S(sve_cmpne_ppzw_s, uint32_t, uint64_t, !=)
> +DO_CMP_PPZW_B(sve_cmpne_ppzw_b, int8_t, uint64_t, !=)
> +DO_CMP_PPZW_H(sve_cmpne_ppzw_h, int16_t, uint64_t, !=)
> +DO_CMP_PPZW_S(sve_cmpne_ppzw_s, int32_t, uint64_t, !=)
>
> DO_CMP_PPZW_B(sve_cmpgt_ppzw_b, int8_t, int64_t, >)
> DO_CMP_PPZW_H(sve_cmpgt_ppzw_h, int16_t, int64_t, >)
> --
> 2.17.1
>
- [Qemu-arm] [PATCH 0/4] target/arm sve fixes, Richard Henderson, 2018/08/01
- [Qemu-arm] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw, Richard Henderson, 2018/08/01
- [Qemu-arm] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64, Richard Henderson, 2018/08/01
- [Qemu-arm] [PATCH 3/4] target/arm: Reorganize SVE WHILE, Richard Henderson, 2018/08/01
- [Qemu-arm] [PATCH 4/4] target/arm: Fix typo in helper_sve_movz_d, Richard Henderson, 2018/08/01
- Re: [Qemu-arm] [PATCH 0/4] target/arm sve fixes, Laurent Desnogues, 2018/08/01