Re: [Qemu-arm] [PATCH 08/16] hw/misc/iotkit-secctl: Wire up registers for controlling MSCs

[Peter Maydell]

On 18 August 2018 at 01:37, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 08/09/2018 10:01 AM, Peter Maydell wrote:
>> The IoTKit does not have any Master Security Contollers itself,
>> but it does provide registers in the secure privilege control
>> block which allow control of MSCs in the external system.
>> Add support for these registers.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---

>>      case A_SECMSCINTEN:
>> -        qemu_log_mask(LOG_UNIMP,
>> -                      "IoTKit SecCtl S block write: "
>> -                      "unimplemented offset 0x%x\n", offset);
>
> Maybe:
>
>            if (value & ~0xffff) {
>                GUEST_ERROR(...)
>            }

We don't generally bother to log writes of raz bits as errors.


thanks
-- PMM