[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 6/8] hw/display/bcm2835_fb: Fix handl
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 6/8] hw/display/bcm2835_fb: Fix handling of virtual framebuffer |
Date: |
Thu, 23 Aug 2018 21:44:07 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/14/2018 07:44 AM, Peter Maydell wrote:
> The raspi framebuffir in bcm2835_fb supports the definition
framebuffer.
> of a virtual "viewport", which is smaller than the full
> physical framebuffer size and at an adjustable offset within
> it. Only the viewport area is sent to the screen. This allows
> the guest to do things like double buffering, or scrolling
> by adjusting the viewport origin. Currently QEMU doesn't
> implement this at all.
>
> Add support for this feature:
> * the property mailbox code needs to distinguish the
> virtual width/height from the physical width/height
> * the framebuffer code needs to do something with the
> virtual width/height/origin information
>
> Note that the wiki documentation on the semantics of the
> virtual and physical height and width has it the wrong way
> around -- the virtual size is the size of the allocated
> buffer, and the physical size is the size of the display,
> so the virtual size is always the same as or larger than
> the physical.
>
> If the viewport size is set smaller than the physical
> screen size, we ignore the viewport settings completely
> and just display the physical screen area.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> include/hw/display/bcm2835_fb.h | 6 ++++--
> hw/display/bcm2835_fb.c | 28 ++++++++++++++++++++++------
> hw/misc/bcm2835_property.c | 21 +++++++++++++++------
> 3 files changed, 41 insertions(+), 14 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-arm] [Qemu-devel] [PATCH 2/8] hw/misc/bcm2835_property: Track fb settings using BCM2835FBConfig, (continued)
- [Qemu-arm] [PATCH 4/8] hw/display/bcm2835_fb: Reset resolution, etc correctly, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 5/8] hw/display/bcm2835_fb: Abstract out calculation of pitch, size, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 1/8] hw/misc/bcm2835_fb: Move config fields to their own struct, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 7/8] hw/display/bcm2835_fb: Validate config settings, Peter Maydell, 2018/08/14
- [Qemu-arm] [PATCH 6/8] hw/display/bcm2835_fb: Fix handling of virtual framebuffer, Peter Maydell, 2018/08/14
- Re: [Qemu-arm] [Qemu-devel] [PATCH 6/8] hw/display/bcm2835_fb: Fix handling of virtual framebuffer,
Richard Henderson <=
- [Qemu-arm] [PATCH 8/8] hw/display/bcm2835_fb: Validate bcm2835_fb_mbox_push() config, Peter Maydell, 2018/08/14
- Re: [Qemu-arm] [PATCH 0/8] arm/raspi: Make fb handle virtual viewport, Peter Maydell, 2018/08/23