Re: [Qemu-arm] [PATCH v2] hw/intc/arm_gic: Document QEMU interface

[Luc Michel]

On 8/23/18 12:38 PM, Peter Maydell wrote:
> The GICv2's QEMU interface (sysbus MMIO regions, IRQs,
> etc) is now quite complicated with the addition of the
> virtualization extensions. Add a comment in the header
> file which documents it.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> I needed to write this out to figure out what I was
> connecting to what in the a15mpcore object :-)
> 
> v1->v2 changes: fixed errors in sysbus IRQ and per-cpu GICH
> memory region docs pointed out by Luc.
> 
>  include/hw/intc/arm_gic.h | 43 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/include/hw/intc/arm_gic.h b/include/hw/intc/arm_gic.h
> index 42bb535fd45..1af5051ed5d 100644
> --- a/include/hw/intc/arm_gic.h
> +++ b/include/hw/intc/arm_gic.h
> @@ -18,6 +18,49 @@
>   * with this program; if not, see <http://www.gnu.org/licenses/>.
>   */
>  
> +/*
> + * QEMU interface:
> + *  + QOM property "num-cpu": number of CPUs to support
> + *  + QOM property "num-irq": number of IRQs (including both SPIs and PPIs)
> + *  + QOM property "revision": GIC version (1 or 2), or 0 for the 11MPCore 
> GIC
> + *  + QOM property "has-security-extensions": set true if the GIC should
> + *    implement the security extensions
> + *  + QOM property "has-virtualization-extensions": set true if the GIC 
> should
> + *    implement the virtualization extensions
> + *  + unnamed GPIO inputs: (where P is number of PPIs, i.e. num-irq - 32)
I think here it's "where P is the number of SPIs".

Apart from that:

Reviewed-by: Luc Michel <address@hidden>

-- 
Luc

> + *    [0..P-1]  SPIs
> + *    [P..P+31] PPIs for CPU 0
> + *    [P+32..P+63] PPIs for CPU 1
> + *    ...
> + *  + sysbus IRQs: (in order; number will vary depending on number of cores)
> + *    - IRQ for CPU 0
> + *    - IRQ for CPU 1
> + *      ...
> + *    - FIQ for CPU 0
> + *    - FIQ for CPU 1
> + *      ...
> + *    - VIRQ for CPU 0 (exists even if virt extensions not present)
> + *    - VIRQ for CPU 1 (exists even if virt extensions not present)
> + *      ...
> + *    - VFIQ for CPU 0 (exists even if virt extensions not present)
> + *    - VFIQ for CPU 1 (exists even if virt extensions not present)
> + *      ...
> + *    - maintenance IRQ for CPU i/f 0 (only if virt extensions present)
> + *    - maintenance IRQ for CPU i/f 1 (only if virt extensions present)
> + *  + sysbus MMIO regions: (in order; numbers will vary depending on
> + *    whether virtualization extensions are present and on number of cores)
> + *    - distributor registers (GICD*)
> + *    - CPU interface for the accessing core (GICC*)
> + *    - virtual interface control registers (GICH*) (only if virt extns 
> present)
> + *    - virtual CPU interface for the accessing core (GICV*) (only if virt)
> + *    - CPU 0 CPU interface registers
> + *    - CPU 1 CPU interface registers
> + *      ...
> + *    - CPU 0 virtual interface control registers (only if virt extns 
> present)
> + *    - CPU 1 virtual interface control registers (only if virt extns 
> present)
> + *      ...
> + */
> +
>  #ifndef HW_ARM_GIC_H
>  #define HW_ARM_GIC_H
>  
>

signature.asc
Description: OpenPGP digital signature