[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] target/arm: Initialize ARMMMUFaultIn
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] target/arm: Initialize ARMMMUFaultInfo in v7m_stack_read/write |
|
Date: |
Thu, 11 Oct 2018 10:44:48 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/11/18 10:20 AM, Peter Maydell wrote:
> The get_phys_addr() functions take a pointer to an ARMMMUFaultInfo
> struct, which they fill in only if a fault occurs. This means that
> the caller must always zero-initialize the struct before passing
> it in. We forgot to do this in v7m_stack_read() and v7m_stack_write().
> Correct the error.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Noticed this in passing while I was working in the file on
> an entirely different issue.
>
> target/arm/helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~