[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 5/6] accel/tcg: Return -1 for executi
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 5/6] accel/tcg: Return -1 for execution from MMIO regions in get_page_addr_code() |
|
Date: |
Thu, 15 Nov 2018 17:00:58 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 11/15/18 2:53 PM, Peter Maydell wrote:
>> switch (offset) {
>> - case 0x0000 ... 0xc000:
>> + case 0x0000 ... 0xbfff:
>> return lduw_le_p(s->boot[0] + addr);
>>
>> case 0xf000: /* Manufacturer ID */
>>
>> as the memory segment has size 0xc000.
>
> Presumably it should be ... 0xbffe, since we are
> doing a 16-bit load ?
Ah, true.
> Yeah, I'll put together a patch which makes it use the qemu_log
> facilities rather than fprintf() and hw_error(). With that
> plus the case statement fix then QEMU correctly just sits there
> as the guest execution races through memory...
Excellent, thanks.
r~