[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v6 06/16] gdbstub: add multiprocess support to 'sC
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-arm] [PATCH v6 06/16] gdbstub: add multiprocess support to 'sC' packets |
Date: |
Fri, 16 Nov 2018 10:57:45 +0100 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Thu, Nov 15, 2018 at 10:41:57AM +0100, Luc Michel wrote:
> Change the sC packet handling to support the multiprocess extension.
> Instead of returning the first thread, we return the first thread of the
> current process.
>
> Signed-off-by: Luc Michel <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> gdbstub.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index f1ec3481cb..d19b0137e8 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1546,13 +1546,18 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> type = strtoul(p, (char **)&p, 16);
> sstep_flags = type;
> put_packet(s, "OK");
> break;
> } else if (strcmp(p,"C") == 0) {
> - /* "Current thread" remains vague in the spec, so always return
> - * the first CPU (gdb returns the first thread). */
> - put_packet(s, "QC1");
> + /* "Current thread" remains vague in the spec, so always return
> the
> + * first thread of the current process (gdb returns the first
> + * thread).
> + */
> + cpu = get_first_cpu_in_process(s, gdb_get_cpu_process(s,
> s->g_cpu));
> + snprintf(buf, sizeof(buf), "QC%s",
> + gdb_fmt_thread_id(s, cpu, thread_id,
> sizeof(thread_id)));
> + put_packet(s, buf);
> break;
> } else if (strcmp(p,"fThreadInfo") == 0) {
> s->query_cpu = first_cpu;
> goto report_cpuinfo;
> } else if (strcmp(p,"sThreadInfo") == 0) {
> --
> 2.19.1
>
- Re: [Qemu-arm] [PATCH v6 12/16] gdbstub: add support for vAttach packets, (continued)
- [Qemu-arm] [PATCH v6 08/16] gdbstub: add multiprocess support to Xfer:features:read:, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 16/16] arm/xlnx-zynqmp: put APUs and RPUs in separate CPU clusters, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 05/16] gdbstub: add multiprocess support to vCont packets, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 06/16] gdbstub: add multiprocess support to 'sC' packets, Luc Michel, 2018/11/15
- Re: [Qemu-arm] [PATCH v6 06/16] gdbstub: add multiprocess support to 'sC' packets,
Edgar E. Iglesias <=
- [Qemu-arm] [PATCH v6 15/16] gdbstub: add multiprocess extension support, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 10/16] gdbstub: add multiprocess support to 'D' packets, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 09/16] gdbstub: add multiprocess support to gdb_vm_state_change(), Luc Michel, 2018/11/15