[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing
Re: [Qemu-arm] [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing foradding configure interface
Sat, 1 Dec 2018 17:28:49 +0800 (CST)
>On Fri, 30 Nov 2018 at 16:14, Andrew Jones <address@hidden> wrote:
>> On Fri, Nov 30, 2018 at 03:57:13PM +0000, Peter Maydell wrote:
>> > On Fri, 30 Nov 2018 at 15:56, Peter Maydell <address@hidden> wrote:
>> > > I suspect the reason you've done this is that you're
>> > > trying to get "-device pvpanic" to work on the command
>> > > line. I recommend not trying to get that to work.
>> > > MMIO devices are not pluggable devices, and -device
>> > > is not expected to work with them.
>> > If you do want a pluggable pvpanic device for the virt
>> > board then you should implement it as a PCI device,
>> > incidentally.
>> We'd have to allocate it a PCI device ID, but I guess that's OK as
>> there are plenty of IDs left for 1b36. I'm not sure it's worth it
>> though. Phil asked that this device by user creatable, but maybe
>> that's not necessary. Maybe we just need a mach-virt compat boolean
>> and then to always provide this device for 4.0 and later machines?
>Yes, if it's just an mmio device then we should either:
>* default to providing it, with the usual flag to say "don't create
>in older virt board versions", and also a machine property to
>disable it manually (like we do with the ITS)
>* default to not providing it at all, and have a machine
>property to enable it (like we do with the IOMMU)
>Which is all doable, but every time we do that it makes the
>virt board code that extra bit more complicated (we have
>half a dozen machine properties on it already).
>This kind of thing is why a PCI device is cleaner -- it just
>works on any machine with a PCI controller, it by default is
>something that the user can provide if they want to and not if
>they don't, and it's not a custom UI that management layers
>might need to special-case. The guest does need to do a bit
>of PCI probing and setup initially, but then it can just leave
>the MMIO BAR permanently mapped and write to that address
>when the guest panics.
Usually, it doesn't matter if there is this pvpanic device or not, so I
haven't considered configurability from the beginning.
I didn't expect you to strongly recommend the use of PCI devices.
Doing so is not just going to roll back some of the code in the kernel...
I'll think about your suggestions.
- Re: [Qemu-arm] [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing foradding configure interface,