[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 09/16] hw/devices: Move TI touchscreen declaration
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-arm] [PATCH 09/16] hw/devices: Move TI touchscreen declarations into a new header |
|
Date: |
Mon, 7 Jan 2019 09:02:53 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/7/19 8:22 AM, Thomas Huth wrote:
> On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
>> Since uWireSlave is only used in this new header, there is no
>> need to expose it via "qemu/typedefs.h".
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> MAINTAINERS | 2 ++
>> hw/arm/nseries.c | 2 +-
>> hw/arm/palm.c | 2 +-
>> hw/input/tsc2005.c | 2 +-
>> hw/input/tsc210x.c | 4 ++--
>> include/hw/arm/omap.h | 6 +-----
>> include/hw/devices.h | 14 --------------
>> include/hw/input/ti_uwire_tsc.h | 28 ++++++++++++++++++++++++++++
>
> I'd maybe rather name the new file "tsc2xxx.h" instead, so that it
> resembles the names of the .c files. Just my 0.02 €.
Good idea :)
- [Qemu-arm] [PATCH 06/16] hw/devices: Move CBus declarations into a new header, (continued)
[Qemu-arm] [PATCH 09/16] hw/devices: Move TI touchscreen declarations into a new header, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-arm] [PATCH 10/16] typedefs: Remove MouseTransformInfo, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-arm] [PATCH 11/16] typedefs: Remove PS2State, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-arm] [PATCH 12/16] hw/devices: Move LAN9118 declarations into a new header, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-arm] [PATCH 13/16] hw/net/ne2000-isa: Add guards to the header, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-arm] [PATCH 14/16] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string, Philippe Mathieu-Daudé, 2019/01/04
[Qemu-arm] [PATCH 15/16] hw/devices: Move SMSC 91C111 declaration into a new header, Philippe Mathieu-Daudé, 2019/01/04