[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH v4] Support u-boot noload images for

From: Peter Maydell
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.
Date: Mon, 7 Jan 2019 10:30:06 +0000

On Mon, 7 Jan 2019 at 07:54, Nick Hudson <address@hidden> wrote:
> On 06/01/2019 22:56, address@hidden wrote:
> > This series seems to have some coding style problems. See output below for
> > more information:
> The files being touched have lots of coding style problems already.  I'm
> avoiding i) fixing these in the same diff for clarity and ii) in the
> case of IH_TYPE_KERNEL_NOLOAD, following existing formatting.

Our usual rule of thumb is "keep checkpatch happy", ie don't introduce
new style issues, even if the code being modified is a bit messy.
In this case it's no big deal -- if you've already sent v5 I can
just wrap the long lines when I apply the patch to my tree.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]