[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH] exec.c: Use correct attrs in cpu_mem

From: Stefano Garzarella
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH] exec.c: Use correct attrs in cpu_memory_rw_debug()
Date: Thu, 17 Jan 2019 15:28:36 +0100
User-agent: NeoMutt/20180716

On Thu, Jan 17, 2019 at 01:38:34PM +0000, Peter Maydell wrote:
> In the softmmu version of cpu_memory_rw_debug(), we ask the
> CPU for the attributes to use for the virtual memory access,
> and we correctly use those to identify the address space
> index. However, we were not passing them in to the
> address_space_write_rom() and address_space_rw() functions.
> The effect of this was that a memory access from the gdbstub
> to a device which had behaviour that was sensitive to the
> memory attributes (such as some ARMv8M NVIC registers) was
> incorrectly always performed as if non-secure, rather than
> using the right security state for the CPU's current state.
> Fixes: https://bugs.launchpad.net/qemu/+bug/1812091
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  exec.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Stefano Garzarella <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]