[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/4] memory: add memory_region_flush_
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/4] memory: add memory_region_flush_rom_device()
Wed, 23 Jan 2019 21:13:30 +0000
On Wed, 23 Jan 2019 at 21:07, Stefan Hajnoczi <address@hidden> wrote:
> On Tue, Jan 22, 2019 at 04:36:36PM +0000, Peter Maydell wrote:
> > API and implementation make sense to me, but better that Paolo reviews
> > this I think. I guess we should add calls to this to the pflash device
> > models too...
> Okay, will cover pflash in the next revision.
We can do that as a separate patch, since it's not related to
the microbit work. For this lot we just need to make a decision
about whether to do this this way or have as Paolo suggested
"memory_region_invalidate_and_set_dirty()". I don't have a
strong opinion, and it sounded like Paolo didn't either, so
let's go with the code you have here.
I can take this patchset via target-arm.next.