[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH] target/arm: Don't clear supported PMU events when

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH] target/arm: Don't clear supported PMU events when initializing PMCEID1
Date: Thu, 24 Jan 2019 13:26:06 +0000

On Wed, 23 Jan 2019 at 19:59, Aaron Lindsay OS
<address@hidden> wrote:
> A bug was introduced during a respin of:
>         commit 57a4a11b2b281bb548b419ca81bfafb214e4c77a
>         target/arm: Add array for supported PMU events, generate 
> PMCEID[01]_EL0
> This patch introduced two calls to get_pmceid() during CPU
> initialization - one each for PMCEID0 and PMCEID1. In addition to
> building the register values, get_pmceid() clears an internal array
> mapping event numbers to their implementations (supported_event_map)
> before rebuilding it. This is an optimization since much of the logic is
> shared. However, since it was called twice, the contents of
> supported_event_map reflect only the events in PMCEID1 (the second call
> to get_pmceid()).
> Fix this bug by moving the initialization of PMCEID0 and PMCEID1 back
> into a single function call, and name it more appropriately since it is
> doing more than simply generating the contents of the PMCEID[01]
> registers.
> Signed-off-by: Aaron Lindsay <address@hidden>

Applied to target-arm.next, thanks.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]