Re: [Qemu-arm] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

[Richard Henderson]

On 1/31/19 5:40 PM, Catherine Ho wrote:
> The lo,hi order is different from the comments. And in commit
> 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128"), it changes
> the original code logic. So just restore the old code logic before this 
> commit:
> do_paired_cmpxchg64_be():
>     cmpv = int128_make128(env->exclusive_high, env->exclusive_val);
>     newv = int128_make128(new_hi, new_lo);
> 
> Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128")
> 
> Signed-off-by: Catherine Ho <address@hidden>
> ---


Reviewed-by: Richard Henderson <address@hidden>


r~