|
From: | Laurent Vivier |
Subject: | Re: [Qemu-arm] [Qemu-devel] [PATCH v4 19/24] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail |
Date: | Tue, 7 May 2019 17:09:06 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/05/2019 19:33, Richard Henderson wrote:
The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of rolling our own error handling locally. Cc: address@hidden Cc: Andrew Baumann <address@hidden> Reviewed-by: Philippe Mathieu-Daudé <address@hidden> Signed-off-by: Richard Henderson <address@hidden> --- hw/misc/bcm2835_rng.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-)
Reviewed-by: Laurent Vivier <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |