Re: [Qemu-arm] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG

[Peter Maydell]

On Fri, 10 May 2019 at 02:25, Richard Henderson
<address@hidden> wrote:
>
> Cc: address@hidden
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> v3: Log errors with -d unimp, for lack of a better flag.
> ---
>  target/arm/cpu.h    |  5 +++++
>  target/arm/cpu64.c  |  1 +
>  target/arm/helper.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 50 insertions(+)

> +/* We do not support re-seeding, so the two registers operate the same.  */
> +static const ARMCPRegInfo rndr_reginfo[] = {
> +    { .name = "RNDR", .state = ARM_CP_STATE_AA64,
> +      .type = ARM_CP_NO_RAW | ARM_CP_SUPPRESS_TB_END,
> +      .opc0 = 3, .opc1 = 3, .crn = 2, .crm = 4, .opc2 = 0,
> +      .access = PL0_R, .readfn = rndr_readfn },
> +    { .name = "RNDRRS", .state = ARM_CP_STATE_AA64,
> +      .type = ARM_CP_NO_RAW | ARM_CP_SUPPRESS_TB_END,
> +      .opc0 = 3, .opc1 = 3, .crn = 2, .crm = 4, .opc2 = 1,
> +      .access = PL0_R, .readfn = rndr_readfn },

Don't these need to be marked ARM_CP_IO for the benefit
of -icount ?

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM