[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 1/2] hw/acpi: Consolidate build_mc
|
From: |
Igor Mammedov |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 1/2] hw/acpi: Consolidate build_mcfg to pci.c |
|
Date: |
Tue, 21 May 2019 16:15:04 +0200 |
On Mon, 20 May 2019 23:37:46 -0400
"Michael S. Tsirkin" <address@hidden> wrote:
> On Tue, May 21, 2019 at 11:32:48AM +0800, Wei Yang wrote:
> > Now we have two identical build_mcfg functions.
> >
> > Consolidate them in acpi/pci.c.
> >
> > Signed-off-by: Wei Yang <address@hidden>
> >
> > ---
> > v5:
> > * ACPI_PCI depends on both ACPI and PCI
> > * rebase on latest master, adjust arm Kconfig
> > v3:
> > * adjust changelog based on Igor's suggestion
> > ---
>
>
> same as 2/2 - do not use two --- separators pls.
I don't really get this requirement, it's common practice on
list(s) and used to work just fine.
The 1st separator is added by hand when editing commit message
to separate change log from main commit message so that 'git am'
would drop change log. While the second separator is added
automatically by git when patch is created.