Re: [Qemu-arm] [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting at translate time

[Philippe Mathieu-Daudé]

On 7/4/19 12:21 PM, Alex Bennée wrote:
> 
> Richard Henderson <address@hidden> writes:
> 
>> On 7/3/19 5:52 PM, Alex Bennée wrote:
>>> +static inline void gen_thumb_bkpt(DisasContext *s, int imm8)
>>> +{
>>> +    if (arm_dc_feature(s, ARM_FEATURE_M) &&
>>> +        semihosting_enabled() &&
>>> +#ifndef CONFIG_USER_ONLY
>>> +        s->current_el != 0 &&
>>> +#endif
>>> +        (imm8 == 0xab)) {
>>
>> Extra parenthesis.
> 
> The wrapping on imm8 == 0xab? Do you want that cleaned up on the other
> patches as well?

I understood this comment for "(s->current_el != 0) &&"