Re: [Qemu-arm] [PATCH-for-4.2 v10 09/11] docs/specs: Add ACPI GED documentation

[Peter Maydell]

On Wed, 4 Sep 2019 at 09:58, Shameer Kolothum
<address@hidden> wrote:
>
> Documents basic concepts of ACPI Generic Event device(GED)
> and interface between QEMU and the ACPI BIOS.
>
> Signed-off-by: Shameer Kolothum <address@hidden>
> Reviewed-by: Eric Auger <address@hidden>
> ---
>  docs/specs/acpi_hw_reduced_hotplug.txt | 60 ++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 docs/specs/acpi_hw_reduced_hotplug.txt

New documentation in docs/specs should be in .rst format
and listed in docs/specs/index.rst, please. That way
it gets built into the sphinx manual sets we're transitioning
to. The rst markup should hopefully not be too difficult to add.


Some minor typo/grammar fixes below:

> +GED allows HW reduced platforms to handle interrupts in ACPI ASL
> +statements. It follows a very similar approach like the _EVT method

"similar approach to the"

> +from GPIO events. All interrupts are listed in  _CRS and the handler
> +is written in _EVT method. However, Qemu implementation uses a single

"the QEMU implementation"

>+ interrupt for the GED device, relying on IO memory region to communicate

"on an IO memory region"

> +the type of device affected by the interrupt. This way, we can support
> +up to 32 events with a unique interrupt.

> +    [0x0-0x3] Event selector bit field(32 bit) set by Qemu.

Missing space before '('.
"QEMU" should be all-capitals.

thanks
-- PMM