[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/16] podman: fix command invocation
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v2 05/16] podman: fix command invocation |
Date: |
Mon, 23 Sep 2019 14:47:17 -0400 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Thu, Sep 19, 2019 at 06:10:04PM +0100, Alex Bennée wrote:
> From: John Snow <address@hidden>
>
> Oops; there's no argv here.
>
> Signed-off-by: John Snow <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Cleber Rosa <address@hidden>
Tested-by: Cleber Rosa <address@hidden>
> ---
> tests/docker/docker.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 4dca6006d2f..890e874ba93 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -338,7 +338,7 @@ class Docker(object):
> cmd = [ "-u", str(uid) ] + cmd
> # podman requires a bit more fiddling
> if self._command[0] == "podman":
> - argv.insert(0, '--userns=keep-id')
> + cmd.insert(0, '--userns=keep-id')
>
> ret = self._do_check(["run", "--label",
> "com.qemu.instance.uuid=" + label] + cmd,
> --
> 2.20.1
>
>
- [PATCH v2 10/16] tests/tcg: add generic version of float_convs, (continued)
[PATCH v2 04/16] tests/docker: reduce scary warnings from failed inspect, Alex Bennée, 2019/09/19
[PATCH v2 01/16] tests/docker: add sanitizers back to clang build, Alex Bennée, 2019/09/19
[PATCH v2 05/16] podman: fix command invocation, Alex Bennée, 2019/09/19
- Re: [PATCH v2 05/16] podman: fix command invocation,
Cleber Rosa <=
[PATCH v2 09/16] tests/tcg: add float_madds test to multiarch, Alex Bennée, 2019/09/19
[PATCH v2 03/16] tests/docker: remove python2.7 from docker9-mxe, Alex Bennée, 2019/09/19
[PATCH v2 02/16] tests/docker: fix DOCKER_PARTIAL_IMAGES, Alex Bennée, 2019/09/19