Re: [PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
3ee4459 hw: Move BCM2835 AUX device from hw/char/ to hw/misc/
4109add hw/char/bcm2835_aux: Use the BCM2835 miniuart block
c19904e hw/char: Add the BCM2835 miniuart

=== OUTPUT BEGIN ===
1/3 Checking commit c19904eab80f (hw/char: Add the BCM2835 miniuart)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 380 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit 4109addacc9f (hw/char/bcm2835_aux: Use the BCM2835 miniuart 
block)
ERROR: do not initialise statics to 0 or NULL
#73: FILE: hw/char/bcm2835_aux.c:28:
+static const bool aux_enable_supported = false;

total: 1 errors, 0 warnings, 397 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 3ee4459660f9 (hw: Move BCM2835 AUX device from hw/char/ to 
hw/misc/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
rename from hw/char/bcm2835_aux.c

total: 0 errors, 1 warnings, 48 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden