[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 24/24] target/arm: Rely on hflags correct in cpu_get_tb_cpu_st
From: |
Richard Henderson |
Subject: |
[PATCH v9 24/24] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state |
Date: |
Wed, 23 Oct 2019 11:00:57 -0400 |
This is the payoff.
>From perf record -g data of ubuntu 18 boot and shutdown:
BEFORE:
- 23.02% 2.82% qemu-system-aar [.] helper_lookup_tb_ptr
- 20.22% helper_lookup_tb_ptr
+ 10.05% tb_htable_lookup
- 9.13% cpu_get_tb_cpu_state
3.20% aa64_va_parameters_both
0.55% fp_exception_el
- 11.66% 4.74% qemu-system-aar [.] cpu_get_tb_cpu_state
- 6.96% cpu_get_tb_cpu_state
3.63% aa64_va_parameters_both
0.60% fp_exception_el
0.53% sve_exception_el
AFTER:
- 16.40% 3.40% qemu-system-aar [.] helper_lookup_tb_ptr
- 13.03% helper_lookup_tb_ptr
+ 11.19% tb_htable_lookup
0.55% cpu_get_tb_cpu_state
0.98% 0.71% qemu-system-aar [.] cpu_get_tb_cpu_state
0.87% 0.24% qemu-system-aar [.] rebuild_hflags_a64
Before, helper_lookup_tb_ptr is the second hottest function in the
application, consuming almost a quarter of the runtime. Within the
entire execution, cpu_get_tb_cpu_state consumes about 12%.
After, helper_lookup_tb_ptr has dropped to the fourth hottest function,
with consumption dropping to a sixth of the runtime. Within the
entire execution, cpu_get_tb_cpu_state has dropped below 1%, and the
supporting function to rebuild hflags also consumes about 1%.
Assertions are retained for --enable-debug-tcg.
Tested-by: Alex Bennée <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
v2: Retain asserts for future debugging.
---
target/arm/helper.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index c55783e540..63815fc4cf 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -11259,12 +11259,15 @@ void HELPER(rebuild_hflags_a64)(CPUARMState *env, int
el)
void cpu_get_tb_cpu_state(CPUARMState *env, target_ulong *pc,
target_ulong *cs_base, uint32_t *pflags)
{
- uint32_t flags, pstate_for_ss;
+ uint32_t flags = env->hflags;
+ uint32_t pstate_for_ss;
*cs_base = 0;
- flags = rebuild_hflags_internal(env);
+#ifdef CONFIG_DEBUG_TCG
+ assert(flags == rebuild_hflags_internal(env));
+#endif
- if (is_a64(env)) {
+ if (FIELD_EX32(flags, TBFLAG_ANY, AARCH64_STATE)) {
*pc = env->pc;
if (cpu_isar_feature(aa64_bti, env_archcpu(env))) {
flags = FIELD_DP32(flags, TBFLAG_A64, BTYPE, env->btype);
--
2.17.1
- [PATCH v9 14/24] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state, (continued)
- [PATCH v9 14/24] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/23
- [PATCH v9 05/24] target/arm: Split out rebuild_hflags_m32, Richard Henderson, 2019/10/23
- [PATCH v9 18/24] target/arm: Rebuild hflags at CPSR writes, Richard Henderson, 2019/10/23
- [PATCH v9 10/24] target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/23
- [PATCH v9 23/24] linux-user/arm: Rebuild hflags for TARGET_WORDS_BIGENDIAN, Richard Henderson, 2019/10/23
- [PATCH v9 15/24] target/arm: Add HELPER(rebuild_hflags_{a32, a64, m32}), Richard Henderson, 2019/10/23
- [PATCH v9 02/24] target/arm: Split out rebuild_hflags_a64, Richard Henderson, 2019/10/23
- [PATCH v9 08/24] target/arm: Split out rebuild_hflags_aprofile, Richard Henderson, 2019/10/23
- [PATCH v9 01/24] target/arm: Split out rebuild_hflags_common, Richard Henderson, 2019/10/23
- [PATCH v9 21/24] target/arm: Rebuild hflags for M-profile NVIC, Richard Henderson, 2019/10/23
- [PATCH v9 24/24] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state,
Richard Henderson <=
- [PATCH v9 16/24] target/arm: Rebuild hflags at EL changes, Richard Henderson, 2019/10/23
- [PATCH v9 20/24] target/arm: Rebuild hflags for M-profile, Richard Henderson, 2019/10/23
- [PATCH v9 11/24] target/arm: Hoist computation of TBFLAG_A32.VFPEN, Richard Henderson, 2019/10/23
- Re: [PATCH v9 00/24] target/arm: Reduce overhead of cpu_get_tb_cpu_state, Peter Maydell, 2019/10/24