qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] hw/gpio: Fix property accessors of the AST2600 GPIO 1.8V


From: Peter Maydell
Subject: Re: [PATCH 0/2] hw/gpio: Fix property accessors of the AST2600 GPIO 1.8V model
Date: Thu, 24 Oct 2019 11:59:02 +0100

On Wed, 23 Oct 2019 at 14:05, Cédric Le Goater <address@hidden> wrote:
>
> Hello,
>
> The property names of AST2600 GPIO 1.8V model are one character bigger
> than the names of the other ASPEED GPIO model. This change increases
> the string buffer size by one and parses the property name with a
> better pattern.
>
> This fixes the QOM test of the ast2600-evb machine under :
>
>   Apple LLVM version 10.0.0 (clang-1000.10.44.4)
>   Target: x86_64-apple-darwin17.7.0
>   Thread model: posix
>   InstalledDir: /Library/Developer/CommandLineTools/usr/bin
>
> And all tests for the AST2600 EVB machine should now pass !

Aha, thanks for finding this bug. In theory the compiler
could have caught it, but it looks like this isn't one of
the things -Wformat/-Wformat-security check for.

Applied to target-arm.next.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]