[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] ppc/spapr_events: fix potential NULL pointer dereference
From: |
David Gibson |
Subject: |
Re: [PATCH V2] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue |
Date: |
Tue, 26 Nov 2019 10:13:27 +1100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Mon, Nov 25, 2019 at 08:34:51PM +0800, address@hidden wrote:
> From: PanNengyuan <address@hidden>
>
> This fixes coverity issues 68911917:
> 360
> CID 68911917: (NULL_RETURNS)
> 361. dereference: Dereferencing "source", which is known to be
> "NULL".
> 361 if (source->mask & event_mask) {
> 362 break;
> 363 }
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: PanNengyuan <address@hidden>
Applied to ppc-for-4.2, thanks.
> ---
> hw/ppc/spapr_events.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
> index 0e4c195..e355e00 100644
> --- a/hw/ppc/spapr_events.c
> +++ b/hw/ppc/spapr_events.c
> @@ -358,6 +358,7 @@ static SpaprEventLogEntry
> *rtas_event_log_dequeue(SpaprMachineState *spapr,
> rtas_event_log_to_source(spapr,
> spapr_event_log_entry_type(entry));
>
> + g_assert(source);
> if (source->mask & event_mask) {
> break;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature