[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 09/22] target/arm: prepare for multiple dynamic XMLs
From: |
Richard Henderson |
Subject: |
Re: [PATCH v5 09/22] target/arm: prepare for multiple dynamic XMLs |
Date: |
Wed, 15 Jan 2020 12:21:50 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 1/14/20 5:09 AM, Alex Bennée wrote:
> We will want to generate similar dynamic XML for gdbstub support of
> SVE registers (the upstream doesn't use XML). To that end lightly
> rename a few things to make the distinction.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> target/arm/cpu.h | 20 +++++++++++++-------
> target/arm/gdbstub.c | 30 +++++++++++++++---------------
> target/arm/helper.c | 4 ++--
> 3 files changed, 30 insertions(+), 24 deletions(-)
It seems to me, that if vg were present in the xml, and honored by gdb, that
the xml for the rest of the registers *could* describe the maximum register
width as opposed to the current register width. At which point this wouldn't
need to be dynamic at all -- merely have a comment next to ARM_MAX_VQ that
changes must be reflected in the gdb xml file too. Which I expect to never
happen.
But again, this is how gdb works today, so
Acked-by: Richard Henderson <address@hidden>
r~
- [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks), Alex Bennée, 2020/01/14
- [PATCH v5 04/22] gdbstub: move mem_buf to GDBState and use GByteArray, Alex Bennée, 2020/01/14
- [PATCH v5 01/22] gdbstub: make GDBState static and have common init function, Alex Bennée, 2020/01/14
- [PATCH v5 06/22] target/arm: use gdb_get_reg helpers, Alex Bennée, 2020/01/14
- [PATCH v5 05/22] gdbstub: add helper for 128 bit registers, Alex Bennée, 2020/01/14
- [PATCH v5 09/22] target/arm: prepare for multiple dynamic XMLs, Alex Bennée, 2020/01/14
- Re: [PATCH v5 09/22] target/arm: prepare for multiple dynamic XMLs,
Richard Henderson <=
- [PATCH v5 07/22] target/m68k: use gdb_get_reg helpers, Alex Bennée, 2020/01/14
- [PATCH v5 03/22] gdbstub: move str_buf to GDBState and use GString, Alex Bennée, 2020/01/14
- [PATCH v5 11/22] target/arm: default SVE length to 64 bytes for linux-user, Alex Bennée, 2020/01/14
- [PATCH v5 12/22] target/arm: generate xml description of our SVE registers, Alex Bennée, 2020/01/14
- [PATCH v5 14/22] target/arm: don't bother with id_aa64pfr0_read for USER_ONLY, Alex Bennée, 2020/01/14
- [PATCH v5 13/22] tests/tcg: add a configure compiler check for ARMv8.1 and SVE, Alex Bennée, 2020/01/14
- [PATCH v5 08/22] gdbstub: extend GByteArray to read register helpers, Alex Bennée, 2020/01/14