Re: [PATCH 6/6] hw/arm/exynos4210: Connect serial port DMA busy signals with pl330

[Guenter Roeck]

On 1/18/20 12:02 PM, Peter Maydell wrote:
> On Sat, 18 Jan 2020 at 15:08, Guenter Roeck <address@hidden> wrote:
> > Do only the pointers have to be in Exynos4210State, or the entire
> > data structures ? In the armsse code it looks like it is the complete
> > data structures.
>
> Either works. Embedding the entire data structure is the more
> "modern" approach, but we don't generally go to the effort of
> converting from the older style to the newer.
>
> > Also, it seems to me that this means that not only pl330 and uart states
> > are affected, but everything created with qdev_create(). If so, the entire
> > file needs a serious rework, not just its pl330 / uart initialization.
> > Am I missing something ?
>
> Yeah, all that stuff is broken, but don't feel you need to fix it.
> You just brought the pl330 pointers to my attention specifically
> by declaring locals in this patch, at which point it's just
> as easy to put those pointers in the state struct where they
> should be.

I'd rather try to fix it all if I am at it; otherwise it feels kind
of incomplete. Would you be ok with addressing this separately after
the current patch series is accepted ?

Thanks,
Guenter