Re: [PATCH REPOST v3] target/arm/arch_dump: Add SVE notes

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [PATCH REPOST v3] target/arm/arch_dump: Add SVE notes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3df154f target/arm/arch_dump: Add SVE notes

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#22: FILE: include/elf.h:1653:
+#define NT_ARM_SVE^I0x405^I^I/* ARM Scalable Vector Extension$

WARNING: Block comments use a leading /* on a separate line
#22: FILE: include/elf.h:1653:
+#define NT_ARM_SVE     0x405           /* ARM Scalable Vector Extension

ERROR: code indent should never use tabs
#23: FILE: include/elf.h:1654:
+^I^I^I^I^I   registers */$

WARNING: Block comments use * on subsequent lines
#23: FILE: include/elf.h:1654:
+#define NT_ARM_SVE     0x405           /* ARM Scalable Vector Extension
+                                          registers */

WARNING: Block comments use a trailing */ on a separate line
#23: FILE: include/elf.h:1654:
+                                          registers */

total: 2 errors, 3 warnings, 233 lines checked

Commit 3df154fd119b (target/arm/arch_dump: Add SVE notes) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden