Re: [PATCH v3 1/8] dma/pl330: Convert to support tracing

[Guenter Roeck]

On Thu, Jan 23, 2020 at 04:23:59PM +0000, Peter Maydell wrote:
> On Thu, 23 Jan 2020 at 15:51, Peter Maydell <address@hidden> wrote:
> >
> > On Thu, 23 Jan 2020 at 05:25, Guenter Roeck <address@hidden> wrote:
> > >
> > > Replace debug logging code with tracing.
> > >
> > > Reviewed-by: Peter Maydell <address@hidden>
> > > Signed-off-by: Guenter Roeck <address@hidden>
> >
> > This turns out not to compile on OSX, which is a bit
> > stricter about format strings:
> >
> > These two:
> >
> > > +pl330_dmald(uint32_t chan, uint32_t addr, uint32_t size, uint32_t num, 
> > > uint32_t ch) "channel:%"PRId8" address:0x%08"PRIx32" size:0x%"PRIx32" 
> > > num:%"PRId32"%c"
> >
> > > +pl330_dmast(uint32_t chn, uint32_t addr, uint32_t sz, uint32_t num, 
> > > uint32_t c) "channel:%"PRId8" address:0x%08"PRIx32" size:0x%"PRIx32" 
> > > num:%"PRId32" %c"
> >
> > both provoke
> >  error: format specifies type 'char' but the argument has type
> > 'uint32_t' (aka 'unsigned int') [-Werror,-Wformat]
> >
> > because of the last argument.
> >
> > Easy fix would seem to be to change 'uint32_t ch' to 'char ch'
> > (the argument is always a literal constant 'Y' or 'N').
> 
> The 'chan'/'chn' argument is wrong too -- should be uint8_t
> to match the format string and the type of PL330Chan::tag.
> I'll just fix up the pullreq rather than forcing a respin.

Thanks, and sorry for the trouble.

Guenter