Re: [PATCH] tests/acceptance: Add a test for the canon-a1100 machine

[Wainer dos Santos Moschetta]

On 1/27/20 1:41 PM, Philippe Mathieu-Daudé wrote:
> On 1/27/20 4:39 PM, Thomas Huth wrote:
> > On 27/01/2020 16.18, Philippe Mathieu-Daudé wrote:
> > > On 1/27/20 3:41 PM, Thomas Huth wrote:
> > > > The canon-a1100 machine can be used with the Barebox firmware. The
> > > > QEMU Advent Calendar 2018 features a pre-compiled image which we
> > > > can use for testing.
> > > >
> > > > Signed-off-by: Thomas Huth <address@hidden>
> > > > ---
> > > >    tests/acceptance/machine_arm_canon-a1100.py | 33 
> > > > +++++++++++++++++++++


What is the reason for not adding this case in boot_linux_console suite?


> > > >    1 file changed, 33 insertions(+)
> > > >    create mode 100644 tests/acceptance/machine_arm_canon-a1100.py
> > > >
> > > > diff --git a/tests/acceptance/machine_arm_canon-a1100.py
> > > > b/tests/acceptance/machine_arm_canon-a1100.py
> > > > new file mode 100644
> > > > index 0000000000..3888168451
> > > > --- /dev/null
> > > > +++ b/tests/acceptance/machine_arm_canon-a1100.py
> > > > @@ -0,0 +1,33 @@
> > > > +# Functional test that boots the canon-a1100 machine with firmware
> > > > +#
> > > > +# Copyright (c) 2020 Red Hat, Inc.
> > > > +#
> > > > +# Author:
> > > > +#  Thomas Huth <address@hidden>
> > > > +#
> > > > +# This work is licensed under the terms of the GNU GPL, version 2 or
> > > > +# later.  See the COPYING file in the top-level directory.
> > > > +
> > > > +from avocado_qemu import Test
> > > > +from avocado_qemu import wait_for_console_pattern
> > > > +from avocado.utils import archive
> > > > +
> > > > +class CanonA1100Machine(Test):
> > > > +
> > > > +    timeout = 90
> > > > +
> > > > +    def test_arm_canona1100(self):
> > > > +        """
> > > > +        :avocado: tags=arch:arm
> > > > +        :avocado: tags=machine:canon-a1100
> > >
> > > To the maintainer taking this, please add:
> > >
> > >             :avocado: tags=pflash_cfi02
> >
> > Should there be a "device:" between the "=" and the device name? At
> > least I can see some other files using "device:" for similar tags...
>
> Ah yes you are right, it is clearer.


Notice that avocado_qemu won't automatically convert that tag into 
QEMU's -device option, If that is the intention...

Thanks!

- Wainer


>