[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] target/arm/monitor: query-cpu-model-expansion crashed qem
Re: [PATCH v4] target/arm/monitor: query-cpu-model-expansion crashed qemu when using machine type none
Mon, 3 Feb 2020 09:01:01 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1
On 2/3/20 8:54 AM, Peter Maydell wrote:
> On Mon, 3 Feb 2020 at 13:44, Liang Yan <address@hidden> wrote:
>> Commit e19afd566781 mentioned that target-arm only supports queryable
>> cpu models 'max', 'host', and the current type when KVM is in use.
>> The logic works well until using machine type none.
>> For machine type none, cpu_type will be null if cpu option is not
>> set by command line, strlen(cpu_type) will terminate process.
>> So We add a check above it.
>> This won't affect i386 and s390x since they do not use current_cpu.
>> Signed-off-by: Liang Yan <address@hidden>
>> v4: change code style based on the review from Andrew Jones
>> v3: change git commit message
>> v2: fix code style issue
> If a reviewer says "with these changes, reviewed-by:", or
> "otherwise, reviewed-by...", then you should add those tags to
> your commit message, assuming you've only made the changes
> they asked for. That saves them having to look at and reply
> to the patchset again.
> In this case I'll just add them as I add this patch to
> target-arm.next, but if you could handle tags across versions
> for future patchset submissions it makes life a little
> easier for us.
Thanks for the tips, will definitely do in the future.
> Applied to target-arm.next, thanks.
> -- PMM