[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/4] aspeed/smc: Fix number of dummy cycles for FAST_READ_

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 4/4] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command
Date: Thu, 6 Feb 2020 19:39:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/6/20 7:32 PM, Guenter Roeck wrote:
The Linux kernel recently started using FAST_READ_4 commands.
This results in flash read failures. At the same time, the m25p80
emulation is seen to read 8 more bytes than expected. Adjusting the
expected number of dummy cycles to match FAST_READ fixes the problem.

Fixes: f95c4bffdc4c ("aspeed/smc: snoop SPI transfers to fake dummy cycles")
Reviewed-by: Cédric Le Goater <address@hidden>
Signed-off-by: Guenter Roeck <address@hidden>
v2: No change

  hw/ssi/aspeed_smc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 23c8d2f062..0444570750 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -787,11 +787,11 @@ static int aspeed_smc_num_dummies(uint8_t command)
      case FAST_READ:
      case DOR:
      case QOR:
+    case FAST_READ_4:
      case DOR_4:
      case QOR_4:
          return 1;
      case DIOR:
-    case FAST_READ_4:
      case DIOR_4:
          return 2;
      case QIOR:

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]