[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

From: David Hildenbrand
Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback
Date: Mon, 10 Feb 2020 10:29:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

>> Can you look the original value up somehow and us the resize callback
>> only as a notification that something changed? (that value would have to
>> be stored somewhere and migrated I assume - maybe that's already being
>> done)
> Ok. I will take a look at that. But can we instead pass the 
> block->used_length to
> fw_cfg_add_file_callback(). That way we don’t have to change the 
> qemu_ram_resize()
> as well. I think Igor has suggested this before[1] and I had a go at it 
> before coming up
> with the "req_length" proposal here.

You mean, passing the old size as well? I don't see how that will solve
the issue, but yeah, nothing speaks against simply sending the old and
the new size.


David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]