[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] hw/arm/gumstix: Simplify since the machines are little-e

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 1/2] hw/arm/gumstix: Simplify since the machines are little-endian only
Date: Tue, 25 Feb 2020 12:16:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/25/20 12:12 PM, Peter Maydell wrote:
On Sun, 23 Feb 2020 at 23:10, Philippe Mathieu-Daudé <address@hidden> wrote:

From: Philippe Mathieu-Daudé <address@hidden>

As the Connex and Verdex machines only boot in little-endian,
we can simplify the code.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

  static void gumstix_machine_init(void)
+    if (target_words_bigendian()) {
+        return;
+    }

I don't think we really need to do this, do we? We don't
in any of the other arm boards that just assume little-endian.
I think TARGET_WORDS_BIGENDIAN will only be true on Arm for
the BE linux-user targets, never for softmmu.

Also, there's a warning comment in the header file for
the declaration of target_words_bigendian() that says
you probably don't want to use it...

Yes you (and the comment) are right, we should not use this call in target-specific code.

If you drop this, then otherwise
Reviewed-by: Peter Maydell <address@hidden>


-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]